Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(list): fixing scale argument on list's simple story #10966

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore(list): fixing scale argument on list's simple story #10966

merged 1 commit into from
Dec 4, 2024

Conversation

eriklharper
Copy link
Contributor

Related Issue: #7100

Summary

This PR fixes the simple story for list to correctly set the scale property.

@eriklharper eriklharper requested a review from ashetland December 3, 2024 22:40
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Dec 3, 2024
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 3, 2024
@jcfranco jcfranco changed the title docs(list): fixing scale argument on list's simple story chore(list): fixing scale argument on list's simple story Dec 3, 2024
ashetland
ashetland approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤩 🧹 ✨

@eriklharper
Copy link
Contributor Author

Thanks @jcfranco for updating the conventional commit type! Didn't know which one to use for this guy :)

@eriklharper eriklharper merged commit c94d085 into dev Dec 4, 2024
16 checks passed
@eriklharper eriklharper deleted the eriklharper/fixing-list-scale-story branch December 4, 2024 01:05
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland ashetland approved these changes

Assignees

@eriklharper eriklharper

Labels
docs Issues relating to documentation updates only. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriklharper @ashetland